In Overlay do not call API directly since it does not have access to the token auth. #13420
Conversation
diosmosis
added
not-in-changelog
plugins/Overlay/Controller.php
Outdated
|
|
||
| private function apiRequest($methodName) | ||
| { | ||
| $_GET['method'] = $_POST['method'] = 'Overlay.' . $methodName; |
There was a problem hiding this comment.
is it possible to use Request::processRequest instead of dispatching new request fully?
There was a problem hiding this comment.
I could use new Request(...) (processRequest hard codes some params).
Note: the index() API controller action does some extra stuff, not sure if it will be important to replicate that logic here (now or in the future if anything else is added there).
There was a problem hiding this comment.
I see... new Request should work then. Don't think we need to apply filter limit I suppose from API index.
In Tag Manager we simply set the format directly as we needed it for example in JSON: https://github.com/matomo-org/tag-manager/blob/master/Controller.php#L172-L173
but new Request or Request::... should work 👍
|
Updated. |
|
Closing in favor of #13446 |
Fixes #13406
Authenticating via UI session in API requests is no longer supported.