Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n Fix missing translations in SitesManager and Widgetize #1342

Closed
halfdan opened this issue May 8, 2010 · 8 comments
Closed

i18n Fix missing translations in SitesManager and Widgetize #1342

halfdan opened this issue May 8, 2010 · 8 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@halfdan
Copy link
Member

halfdan commented May 8, 2010

While I was completing the German translation I saw that the SitesManger hasn't been completely enabled for translation. When showing the tracking Tag there are three sentences on the bottom of the page that are hard coded.

I edited the Plugin and added 3 strings to the english translation. If the changes are ok, please check for my naming scheme for the translation string.

The file /plugins/SitesManager/templates/JavascriptTagHelp.tpl can - as far as I can tell - be deleted.
@halfdan
Copy link
Member Author

halfdan commented May 8, 2010

Attachment:
en.php.diff

@halfdan
Copy link
Member Author

halfdan commented May 8, 2010

Attachment:
DisplayJavascriptCode.tpl.diff

@mattab
Copy link
Member

mattab commented May 13, 2010

The reason we didn't translate these for now, is that the English help text wasn't 'final' and could be improved (or changed format, number of sentences, etc.).

A note: when you generate a patch, please try to keep the path (core/Tracker/xx) as it makes applying the patch easier.

i'll move this to 1.0 until the english help text is figured out.

@julienmoumne
Copy link
Member

The file /plugins/SitesManager/templates/JavascriptTagHelp.tpl is also included in /plugins/Installation/templates/displayJavascriptCode.tpl, lign 40 :

{include file=SitesManager/templates/JavascriptTagHelp.tpl}

@julienmoumne
Copy link
Member

/plugins/Widgetize/templates/index.tpl has also non-localized strings.

@mattab
Copy link
Member

mattab commented May 24, 2010

Good point, updated ticket titles

@mattab
Copy link
Member

mattab commented Jul 23, 2010

post 1.0 as translations are too long, technical, and it sounds risky to add them as translations as of yet.

@mattab
Copy link
Member

mattab commented Apr 28, 2011

we might add i18n when implementing Better JS Tracking generator screen: #1845

See #1187

@halfdan halfdan added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@halfdan @mattab @julienmoumne