During visitorgenerator:generate-visits. I am not sure what exactly is the error and if it has anything to do with PHP 7.3.

Not a PHP error, it tries to write -5 into an db field that is unsigned mostlikely. Why it tries to write -5 is a interesting question nethertheless.

Also note that your request contains 2 token_auths, that is quite unusual I would say..

Okay, I have now updated the server to the latest release candidate and tried around and couldn't really find more issues.

For the first two I'll create a pull request soon once tedious/JShrink#80 is fixed.

@fdellwing I agree that this is probably a really obscure visitor generator bug, so I have removed it here.

Interestingly everything around PHP generation still works fine (where I expected most bugs).

As PHP7.3 just migrated to Debian testing, I'll expect it to be the default version in the next Debian stable (will be released in about a year) and ubuntu versions. Therefore probably a lot of people will be using it in a year.

Okay, I mixed a bit up regarding JShirk. We are using a more than 4 year old beta version of it.
The latest version from last month fixes the warnings in PHP 7.3, so it should be easy to update, but unfortunately the recent versions dropped support for 5.5 which causes composer to refuse installing it.

Does anyone have an idea what's the easiest way to fix this?

If the current version is actually still compatible with 5.5, but the dependencies were just changed in the composer.json we could overwrite it with a custom package in composer.json to overwrite the php requirement. e.g.:

{
    "type": "package",
    "package": {
        "name": "tedious/jshrink",
        "description": "Javascript Minifier built in PHP",
        "keywords": ["minifier","javascript"],
        "homepage": "http://github.com/tedious/JShrink",
        "type": "library",
        "license": "BSD-3-Clause",
        "version": "v1.3.1",
        "authors": [
            {
                "name": "Robert Hafner",
                "email": "tedivm@tedivm.com"
            }
        ],
        "require": {
            "php": ">=5.5.0"
        },
        "autoload": {
            "psr-0": {"JShrink": "src/"}
        },
        "source": {
            "type": "git",
            "url": "https://github.com/tedious/JShrink",
            "reference": "v1.3.1"
        }
    }
}

@sgiehl Thanks for the tip.
I had to rename the package so that composer would use it instead of the real one.

Got another one:

"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
/home/travis/build/piwik/vendor/tecnickcom/tcpdf/tcpdf.php:17778

Need to check if that will be fixed with #13566

#11936 is still open. Shouldn't this be resolved first?

Please also clarify this in the docs. Currently it just says "PHP version 5.5.9 or greater".

@sgiehl could you do any hot fix for the tcpdf issue?

@sebash1992 this should be fixed in the upcoming 3.8.0

Replace continue with break resolved the issue.

@Findus23 since JShrink was updated, is this issue done?

@diosmosis If no one else reports any more issues, I'd say this is done.
Next week I'll move my live instance to 7.3 and can probably then report back more issues.