Limit of editing of anonymous user in UI. #13416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
|
Is it possible to show a different warning when giving view access that data will be public? |
|
Updated. |
|
|
|
Lets maybe make the small note big as well if possible? As it is quite important that they read it. |
|
|
tsteur
reviewed
Sep 13, 2018
core/Mail/EmailStyles.php
Outdated
| @@ -89,6 +89,21 @@ class EmailStyles | |||
| */ | |||
| public $brandNameLong; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
are those changes supposed to be in here @diosmosis ?
There was a problem hiding this comment.
no, not sure how they got in, will remove
|
Changes work and good to merge... just need to figure out the email changes 👍 |
diosmosis
force-pushed
the
13412-anonymous-user
branch
from
345509f
to
d02c150
Compare
diosmosis
added a commit
that referenced
this pull request
Sep 20, 2018
* Limit of editing of anonymous user in UI. * Move some email styles to EmailStyles class. * Show special warning when giving anonymous user view role. * Make new text large. * remove accidentally added files
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Limit of editing of anonymous user in UI. * Move some email styles to EmailStyles class. * Show special warning when giving anonymous user view role. * Make new text large. * remove accidentally added files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13412