Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new category profiles plus new visitors report #13414

Closed
wants to merge 4 commits into from
Closed

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Sep 12, 2018

We could also add a Real-Time section as the current real time widgets are not exposed in the UI...

image

Real-Time Map etc may be still better under "Visitors".

Renamed "Visitor Log" to "Visits Log" as this is more accurate, but could also keep the original name.

The "Visitors" report is queried live and not archived as we would otherwise need to archive thousands or millions of rows to make this usable properly.

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 12, 2018
@mattab
Copy link
Member

mattab commented Sep 12, 2018

👍 for adding real time menu, also embedding the map would be awesome.

@tsteur
Copy link
Member Author

tsteur commented Sep 12, 2018

Which map do you mean? visitor map or real time map? or both?

@mattab
Copy link
Member

mattab commented Sep 12, 2018

Real time Map in the real time page

@tsteur
Copy link
Member Author

tsteur commented Sep 13, 2018

Menu currently looking like this:

image

  • Real time visitors is tweaked a little bit to optimize for the available space we have there... (could be done more potentially but is tricky)
  • For visitors report we would need to fix the row action icons see Same icon is used for "segmented visitor log" and "show visitor profile" #13419
  • Quite useful in visitors report the "show profile" button but also the "segmented visitor log" to view all visits of a visitor within a certain range...

@mattab
Copy link
Member

mattab commented Sep 25, 2018

See discussion on this PR in #13419 (comment) (I commented on the wrong issue...)

@tsteur
Copy link
Member Author

tsteur commented Sep 25, 2018

Todo: Need to add "revenue" info but I think this may not be present in visits table and maybe need to add it in Matomo 4

@tsteur
Copy link
Member Author

tsteur commented Oct 1, 2018

FYI: We will keep this issue open for now as we want to see how we can make the profiles report useful as a real time report at some point. For regular report it wouldn't be fast enough unless we created archives for each sort column etc and kept eg only 1000 rows.

menu changes are now in
#13518

@mattab mattab added this to the 3.7.0 milestone Oct 9, 2018
@diosmosis
Copy link
Member

Moving out of this milestone.

@diosmosis diosmosis modified the milestones: 3.8.0, 3.9.0 Dec 12, 2018
@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@mattab mattab modified the milestones: 3.10.0, 4.0.0 May 28, 2019
@tsteur tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:57
@diosmosis
Copy link
Member

@tsteur has some conflicts that need to be resolved (tried myself but wasn't able to determine what to change).

@tsteur
Copy link
Member Author

tsteur commented Feb 7, 2020

@mattab not sure if we still want to have this in Matomo 4 or not? I think we wanted to have a look once we start Matomo 4 or so but not sure.

It's difficult decision... adds yet another menu item, at the same time not everything is 100% profiles maybe? Personally, I'm not yet 100% convinced.

@mattab
Copy link
Member

mattab commented Feb 11, 2020

agreed that adding yet another menu is an issue. Here is an idea: we could show Visits log menu only, and when people click it shows the visits log. then there would be a link/button/tab (above fold) labelled Visitors log and when clicked, it would replace the Visits log with the Visitors log?

@tsteur
Copy link
Member Author

tsteur commented Feb 11, 2020

@mattab from a usability point of view not so great either. Personally, thinking to simply not add this report for now. Not seeing users asking for it? Or maybe there is an issue with some interest? Of course it's a nice to have, but maybe not really really super needed and just cluttering the UI. Also from a privacy point of view it starts making things complicated maybe. (eg once we have feature to disable visitor profile then it also needs to disable this button etc etc. not too much of an issue though).

@tsteur tsteur modified the milestones: 4.0.0, 4.3.0 Jul 28, 2020
@tsteur
Copy link
Member Author

tsteur commented Jul 20, 2021

closing this for now

@tsteur tsteur closed this Jul 20, 2021
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
@sgiehl sgiehl deleted the profiles branch January 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants