Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure action details are sorted stable across PHP versions #13404

Merged
merged 3 commits into from Sep 20, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 10, 2018

serverTimePretty and idlink_va might be the same if e.g. an goal is directly tracked with a page view.
As the action type can be something like action, goal, outlink, search and stuff like that, sorting by type should move the action to top in all cases.
Currently that is not necessarily the case and in the visitor log the action might be shown below the action (which triggered the goal). That can also e seen in the UI changes

@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Sep 10, 2018
@sgiehl sgiehl added this to the 3.6.1 milestone Sep 10, 2018
@sgiehl sgiehl added the Needs Review PRs that need a code review label Sep 15, 2018
@diosmosis diosmosis merged commit 177ceb2 into 3.x-dev Sep 20, 2018
@diosmosis diosmosis deleted the stablesortactions branch September 20, 2018 20:05
diosmosis pushed a commit that referenced this pull request Sep 20, 2018
* Ensure action details are sorted stable across PHP versions

* update expected test files

* Update UI files
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…rg#13404)

* Ensure action details are sorted stable across PHP versions

* update expected test files

* Update UI files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants