Add Matomo Tag Manager to core #13402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a failing system test in Anonymous tracking which will be fixed when merging (to avoid merging PR in submodules etc). There are couple of failing UI tests but I believe some of them fail in 3.x-dev as well. I've been trying to reproduce and fix this failing screenshot https://builds-artifacts.matomo.org/matomo-org/matomo/tagmanager/29950/UIIntegrationTest_admin_manage_tracking_code.png but cannot reproduce it locally when running the UI tests and neither in the browser. Also not seeing any JS error in the UI build test logs. |
|
FYI: I'm currently waiting for a review of the wording on that page. |
tsteur
added
the
Pull Request WIP
tsteur
added
Needs Review
|
Updated wording and added translations. |
diosmosis
reviewed
Nov 4, 2018
|
screenshots need to be updated, otherwise lgtm (tested locally and it works) |
tsteur
added a commit
to matomo-org/matomo-package
that referenced
this pull request
Nov 10, 2018
refs matomo-org/matomo#13402 Haven't tested it but I reckon it should work
mattab
added
the
Major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.