@tsteur opened this Pull Request on September 9th 2018 Member
@tsteur commented on September 12th 2018 Member

There's a failing system test in Anonymous tracking which will be fixed when merging (to avoid merging PR in submodules etc).

There are couple of failing UI tests but I believe some of them fail in 3.x-dev as well.

I've been trying to reproduce and fix this failing screenshot https://builds-artifacts.matomo.org/matomo-org/matomo/tagmanager/29950/UIIntegrationTest_admin_manage_tracking_code.png but cannot reproduce it locally when running the UI tests and neither in the browser. Also not seeing any JS error in the UI build test logs.

@tsteur commented on September 12th 2018 Member

FYI: I'm currently waiting for a review of the wording on that page.

@tsteur commented on October 31st 2018 Member

Updated wording and added translations.

@diosmosis commented on November 9th 2018 Member

screenshots need to be updated, otherwise lgtm (tested locally and it works)

This Pull Request was closed on November 9th 2018
Powered by GitHub Issue Mirror