Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method createTestConfig() in BenchmarkTestCase #13398

Closed
aaaronfeng opened this issue Sep 7, 2018 · 3 comments · Fixed by #15976
Closed

undefined method createTestConfig() in BenchmarkTestCase #13398

aaaronfeng opened this issue Sep 7, 2018 · 3 comments · Fixed by #15976
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@aaaronfeng
Copy link

When I run the tests in the Benchmarks package, I got the following error:

undefined method createTestConfig()

After checking the commit history, the method createTestConfig belong to the class IntegrationTestCase which used to be the superclass of BenchmarkTestCase
@aaaronfeng
Copy link
Author

@diosmosis

abstract class IntegrationTestCase extends PHPUnit_Framework_TestCase
 {
-    /**
-     * Identifies the last language used in an API/Controller call.
-     *
-     * @var string
-     */
-    protected $lastLanguage;
-
-    /**
-     * Creates a config object for use w/ tests.
-     */
-    public static function createTestConfig()
-    {
-        Config::getInstance()->setTestEnvironment();
-    }

@diosmosis
Copy link
Member

I might be wrong, but the benchmark code there isn't really maintained. Could probably be removed at this point. CC @tsteur

@tsteur
Copy link
Member

tsteur commented Sep 7, 2018

Yeah I'd say so, could be removed. I didn't even really know it existed. It isn't maintained and I think even the automated tests might not execute them.

@Findus23 Findus23 mentioned this issue May 23, 2020
Merged
@Findus23 Findus23 linked a pull request May 23, 2020 that will close this issue
remove Benchmark Unit Tests #15976
Merged
@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label May 23, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove Benchmark Unit Tests matomo-org/matomo
5 participants
@diosmosis @tsteur @mattab @Findus23 @aaaronfeng