Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the Upgrade screen, if license is expired, warn users #13383

Closed
mattab opened this issue Sep 4, 2018 · 2 comments
Closed

On the Upgrade screen, if license is expired, warn users #13383

mattab opened this issue Sep 4, 2018 · 2 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
3.8.0

Comments

@mattab
Copy link
Member

mattab commented Sep 4, 2018

During the upgrade process, before users trigger the upgrade, on this screen:

update

Let's display the notification that license is expired, if any:

expired

This will be very valuable because, when license is valid, the updater also tries to update all plugins. This saves a lot of time and is very useful. Yet when license is expired it doesn't work. So it's good to remind people they should have a valid license to benefit from updates.
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Sep 4, 2018
@mattab mattab added this to the 3.7.0 milestone Sep 4, 2018
@tsteur
Copy link
Member

tsteur commented Sep 28, 2018

fyi @mattab I tried to make this work in https://github.com/matomo-org/matomo/compare/13383?expand=1 but it's not really possible / trivial since we are now deactivating any plugin with a disabled license. Therefore I cannot really get the plugin instance and check which feature is a premium feature etc...

Also since Matomo 3.6 as just said we are disabling those plugins and show a notification for it. So maybe this issue is not needed anymore?

@mattab
Copy link
Member Author

mattab commented Sep 28, 2018

Fine, it's not needed

@mattab mattab closed this as completed Sep 28, 2018
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
2 participants
@tsteur @mattab