Login form sometimes submits to CoreHome so must be more lenient in check for form_rememberme. #13333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck for form_rememberme.
tsteur
reviewed
Aug 22, 2018
| @@ -65,7 +65,7 @@ private function shouldHandleRememberMe() | |||
| { | |||
| $module = Common::getRequestVar('module', false); | |||
There was a problem hiding this comment.
Not quite sure I understand shouldHandleRememberMe. Shouldn't remember me be always handled? there could be also maybe a login form when opening multi sites etc?
There was a problem hiding this comment.
In the sessions PR we had a discussion about whether it would be possible for someone to add form_rememberme to a URL and have it extend the session for the user, and this was a way to mitigate it. Basically, if we're detecting a POST by the login form, then we check form_rememberme & change the session time (because if it's not set, then we want it to end with the browser session).
mattab
added
the
answered
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…heck for form_rememberme. (matomo-org#13333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @mattab / @tsteur