Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapping in menu selectors #13320

Merged
merged 1 commit into from Aug 21, 2018
Merged

Fix wrapping in menu selectors #13320

merged 1 commit into from Aug 21, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 20, 2018

When having a long goal name without spaces the name didn't wrap in the menu selector:

image

Same should apply for other selectors like dashboads, sessions,...

@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 20, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Aug 20, 2018
@diosmosis
Copy link
Member

Which dropdown does this affect? I couldn't reproduce using the "Choose Goal" dropdown:
image

Tests look good though, so merging.

@diosmosis diosmosis merged commit 511ce3d into 3.x-dev Aug 21, 2018
@diosmosis diosmosis deleted the menuwrap branch August 21, 2018 02:11
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants