Many thanks for digging into this, @tzhelyazkova!

Thanks for the PR and research @tzhelyazkova, it's very much appreciated! I think you definitely found a bug here, but I'm not sure it's the cause of @KaiNissen's issue.

The code here is part of the code that aggregates log data: it checks if the period is for a single day & site, and if so aggregates the log data. If it isn't, it means the period spans multiple days and the archiver will initiate archiving for each individual day and then aggregate the results for the whole period.

@KaiNissen's issue sounds like pre-archived data from pre-3.0 versions aren't being found for ranges that consist of two adjacent days, so I'm not sure what effect this will have. @KaiNissen are you able to confirm if this fixes the issue for you?

As for the change, I think it could be fixed a bit more generally by changing the <= to < (so if one day is 2018-06-10 and the end is 2018-06-11, it will know it's not a single day). That way it will also be fixed for non-range periods (plugins are able to add custom periods).

@diosmosis We didn't roll it out on our production system, but after applying this to a test system, I wasn't able to reproduce the issue anymore. So yes, this change seems to fix the problem.

By the way, it affects all data that is older than two weeks, not only what has been archived prior to the upgrade.

That's interesting, @KaiNissen, I'm not able to reproduce this on my own. Would you be able to check in your test system if changing the <= to < in https://github.com/matomo-org/matomo/blob/3.x-dev/core/ArchiveProcessor/Parameters.php#L214 also fixes the issue for you?

Hi @KaiNissen @tzhelyazkova could you please check @diosmosis answer in #13315 (comment)

or @diosmosis maybe you have some ideas to could get to the bottom of this issue?

@mattab I'll create a PR w/ a test for the operator bug which we can merge in 3.6.1. If someone else reports the issue then we can debug again?

sounds good 👍

Hey @mattab @diosmosis
Sorry for the late response. I tried replacing <= with < on my test environment, but it doesn't fix the issue. The matomo version is still 3.5.1.
Also when I print $secondsInPeriod it always seems to be int 0. 😕
Thanks for looking into the issue!

@tzhelyazkova could you see what $period->getRangeString() is?

@diosmosis

@tzhelyazkova could you see what $period->getRangeString() is?

It prints a string with the right start and end date I choose as a range period,
e.g. string '2017-02-23,2017-02-24'

@tzhelyazkova apologies for the late reply, just getting back to this. I'm not sure why this is happening, but I have a guess that it might be timezone related. Does your site in Matomo have a specific timezone?

@tzhelyazkova any chance you could maybe reply to @diosmosis question in the last comment?

@diosmosis @tsteur yes, our matomo is in the Europe/Berlin timezone.

@diosmosis do you maybe have a chance to look into this again?

Yes, I'll take a look today.

@tzhelyazkova Well, I'm still unable to reproduce this, but if getRangeString() works while the actual code doesn't, then changing getTimestampUTC() to getTimestamp() might fix the issue for you. Can you try this change: https://github.com/matomo-org/matomo/compare/parameters-date-timezone-check?expand=1?

Hi @tzhelyazkova
Are you still experiencing this issue with the latest version of Matomo?
If so please let us know the steps to reproduce so we have a chance to investigate and fix it.
Thanks,

Closing since original issue is closed.