Use font icon for visitorlog instead of images #13312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
LGTM. UI tests need fixing though: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/29515/ . I presume this test just failed randomly? https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/29515/UIIntegrationTest_goals_ecommerce.png |
|
We often have that "blank screen" random failure these days. Not sure were it comes from and how to fix best, as it occurs for all screens using ajax content. Maybe it's a matter of speed, but adding more wait times makes all tests even slower. |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Use font icon for visitorlog instead of images * Update expected screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13303