CustomVariables: Fix frontend display of value 0 #13295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelRoosz
changed the title
tsteur
approved these changes
Aug 14, 2018
|
Thanks @MichaelHeerklotz for this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 37:
The value of 0 is wrongly displayed as "not defined" because in PHP the statement "0 == 'string value'" equals true. This is because, if you compare an integer with a string in PHP, it converts the string to an integer first (will always be 0 in this case).
Line 39:
After the fix for line 37, the value 0 will be displayed as '-'. with the strval conversion, we will see the real value of '0' in the frontend.