Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three small bug fixes #13288

Merged
merged 7 commits into from Aug 15, 2018
Merged

Three small bug fixes #13288

merged 7 commits into from Aug 15, 2018

Conversation

diosmosis
Copy link
Member

Fixes:

  • Set font style for html report emails for TopOfReport links.
  • Add ng-click to link entity so clicking next to link won't close the user edit form.
  • When getting data to perform bulk actions, make sure no limit is applied.

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 13, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 13, 2018
@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 13, 2018
@mattab
Copy link
Member

mattab commented Aug 14, 2018

@diosmosis the builds are failing, could you please fix & merge?

@diosmosis diosmosis merged commit 7490129 into 3.x-dev Aug 15, 2018
@diosmosis diosmosis deleted the users-manager-bug branch August 15, 2018 02:25
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Three small bug fixes (matomo-org#13288)
75205de 
* Fix two bugs in users manager component (bulk actions were limited to 100 rows and cancel link spanned whole container length).

* Add font styles to top of report link in email.

* remove commas

* Updated expected files.

* update tests again

* update test files again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab