Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable sort for most frequent segment values #13286

Merged
merged 3 commits into from Sep 4, 2018
Merged

Stable sort for most frequent segment values #13286

merged 3 commits into from Sep 4, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 13, 2018

This fixes the test result differences across PHP versions for API.getSuggestedValuesForSegment

Note: CustomDimension plugin will need an update before merging...

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Aug 13, 2018
@mattab mattab added this to the 3.7.0 milestone Aug 17, 2018
@mattab mattab modified the milestones: 3.7.0, 3.6.1 Sep 1, 2018
@diosmosis diosmosis merged commit 7c7f6da into 3.x-dev Sep 4, 2018
@diosmosis diosmosis deleted the stablesort branch September 4, 2018 23:56
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Stable sort for most frequent segment values (matomo-org#13286)
faff0ef 
* Use a stable sort when sorting most frequent segment values

* update test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @mattab