@sgiehl opened this Pull Request on August 13th 2018 Member

As this changes will only affect PHP 7 we shouldn't merge this unless we have successful tests running with PHP 7.

I've switched the tests to PHP 7 on this branch, but it would be good to have them continuous to avoid problems in the future

@mattab commented on August 17th 2018 Member

I've switched the tests to PHP 7 on this branch, but it would be good to have them continuous to avoid problems in the future

as long as we support PHP 5.6 we should still have our Unit+Integration+System tests running 5.6. So maybe you could make the two MySQLI jobs Alltests run php 5.6 ?

@tsteur commented on September 9th 2018 Member

FYI @mattab we support PHP 5.5.9+ unless I missed something?

@mattab commented on September 9th 2018 Member

Yes 👍meant 5.5 not 5.6

@sgiehl commented on September 10th 2018 Member

The UI tests are currently running on PHP 5.5. All other test suites are using PHP 5.6.
I'd suggest to switch the AllTests to PHP 7, so they are running a bit faster. But we need to adjust some more stuff so all tests have the same results across PHP versions.

@diosmosis commented on September 28th 2018 Member

I guess the .travis.yml change needs to be tweaked to whatever is decided upon, otherwise left one comment.

@diosmosis commented on October 9th 2018 Member

Left one comment, otherwise looks good to merge.

This Pull Request was closed on October 10th 2018
Powered by GitHub Issue Mirror