Use Python 2.7 for travis tests #13282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
|
Should not break anything here. |
|
@matomo-org/core-team Anyone having a reason not to merge this? |
|
Python 2.6 has been end-of-life for 5 years and doesn't support essential features like TLS 1.2, so I'd say we shouldn't support it in any way anymore. |
|
@Findus23 Sure. But the log analytics currently only works with 2.6 & 2.7. Guess we should already deprecate usage of python 2.x and migrate the log analytics to Python 3 for at least Matomo 4 |
|
@sgiehl I agree and as I showed in matomo-org/matomo-log-analytics#205 it doesn't take that many changes to get a version that at least passes all tests in python3 |
sgiehl
force-pushed
the
python27
branch
3 times, most recently
from
229048b
to
6f246ec
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* use python 2.7 * adjust travis submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atm travis is having more and more problems with installing Python 2.6 and all builds are failing randomly.
As Python 2.7 is preinstalled we should use that instead. That will allow us to remove the dependency for
deadsnakesapt source and helps to fix the random failures.Personally I don't see any advantage in using the old 2.6 here, as the log importer itself runs it's tests on 2.6 to prove it works...
After merging we need to update all
.travis.ymlfiles of all our plugins...