Always set Auth interface in DI to the correct plugin's Auth implementation #13279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
diosmosis
force-pushed
the
auth-regression
branch
from
1bd1b0f
to
739b4b5
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…tation (matomo-org#13279) * Make sure Auth interface is always set even if session auth succeeds. * Add failing test. * Fix FrontControllerTest * Put hash token authentication back since it is still in use in plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth interface is used for more than authentication, such as getting the configured Login plugin's name, and it is possible for code to try and re-authenticate using the stored auth. In which case, we would always want this interface set to the real implementation.
This PR does that if the SessionAuth succeeds and sets the token auth to the authenticated user's token auth, so reauthentication w/ plugin auths should work (since all Auth implementations are required to support authenticating by token auth alone).
CC @matomo-org/core-team