Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backtrace to exceptions treated as fatal errors #13276

Merged
merged 6 commits into from Aug 12, 2018
Merged

Add backtrace to exceptions treated as fatal errors #13276

merged 6 commits into from Aug 12, 2018

Conversation

diosmosis
Copy link
Member

… and move partial backtrace reconstruction to FrontController so different safemodes can receive it.

@diosmosis
Add backtrace to exceptions treated as fatal errors w/ test, and move…
8b33287 
… partial backtrace reconstruction to FrontController so different safemodes can receive it.
@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 11, 2018
@diosmosis diosmosis added this to the 3.7.0 milestone Aug 11, 2018
@mattab
Copy link
Member

mattab commented Aug 11, 2018

@diosmosis as this looks useful, could you move this to 3.6.0 unless there is some "last minute" risk to it?

@diosmosis
Copy link
Member Author

Don't think there's a risk, will move to 3.6.0

@diosmosis diosmosis modified the milestones: 3.7.0, 3.6.0 Aug 11, 2018
@mattab
Copy link
Member

mattab commented Aug 12, 2018 •
edited

looks good, only noticed Integration tests build fails with

1) Piwik\Tests\Integration\FrontControllerTest::test_thrownExceptionInFrontControllerPrintsBacktrace
Failed asserting that format description matches text.
--- Expected
+++ Actual
@@ @@
-test message on {includePath}/tests/resources/trigger-fatal-exception.php(23)#0 [internal function]: {closure}('CoreHome', 'index', Array)#1 {includePath}/core/EventDispatcher.php(141): call_user_func_array(Object(Closure), Array)#2 {includePath}/core/Piwik.php(780): Piwik\EventDispatcher->postEvent('Request.dispatc...', Array, false, Array)#3 {includePath}/core/FrontController.php(538): Piwik\Piwik::postEvent('Request.dispatc...', Array)#4 {includePath}/core/FrontController.php(146): Piwik\FrontController->doDispatch('CoreHome', 'index', NULL)#5 {includePath}/tests/resources/trigger-fatal-exception.php(31): Piwik\FrontController->dispatch('CoreHome', 'index')#6 {main}
+test message on {includePath}/tests/resources/trigger-fatal-exception.php(23)#0 [internal function]: {closure}('CoreHome', 'index', Array)#1 {includePath}/core/EventDispatcher.php(141): call_user_func_array(Object(Closure), Array)#2 {includePath}/core/Piwik.php(780): Piwik\EventDispatcher->postEvent('Request.dispatc...', Array, false, NULL)#3 {includePath}/core/FrontController.php(538): Piwik\Piwik::postEvent('Request.dispatc...', Array)#4 {includePath}/core/FrontController.php(146): Piwik\FrontController->doDispatch('CoreHome', 'index', NULL)#5 {includePath}/tests/resources/trigger-fatal-exception.php(31): Piwik\FrontController->dispatch('CoreHome', 'index')#6 {main}

@diosmosis diosmosis merged commit 73bc38f into 3.x-dev Aug 12, 2018
@diosmosis diosmosis deleted the 1385-backtrace-fatal branch August 12, 2018 21:48
@mattab mattab changed the title Add backtrace to exceptions treated as fatal errors w/ test, … Add backtrace to exceptions treated as fatal errors Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Add backtrace to exceptions treated as fatal errors w/ test, … (matom…
a0160cd 
…o-org#13276)

* Add backtrace to exceptions treated as fatal errors w/ test, and move partial backtrace reconstruction to FrontController so different safemodes can receive it.

* Add missing file.

* fixing tests

* fix test finally

* fix submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab