Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If warning/error log detected in console command exit w/ code = 1. #13275

Merged
merged 1 commit into from Aug 11, 2018
Merged

If warning/error log detected in console command exit w/ code = 1. #13275

merged 1 commit into from Aug 11, 2018

Conversation

diosmosis
Copy link
Member

No description provided.

@diosmosis diosmosis added this to the 3.6.0 milestone Aug 11, 2018
@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 11, 2018
@mattab
Copy link
Member

mattab commented Aug 11, 2018

Tested and works well and the core:archive returns error code even when php notices are emitted. 👍

@mattab mattab merged commit 2d7896c into 3.x-dev Aug 11, 2018
@mattab mattab deleted the 148-warning-error-exit-code branch August 11, 2018 08:14
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
If warning/error log detected in console command exit w/ code = 1. (m…
ab87019 
…atomo-org#13275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab