New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couple changes to aid debugging #13269
Conversation
core/ErrorHandler.php
Outdated
{ | ||
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, $limit = 2); | ||
$backtrace[1]['class'] = $className; // knowing the derived class name is far more useful | ||
$backtrace[1]['args'] = empty($importantArgs) ? [] : array_map('strval', $importantArgs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you need to json_encode the args or so in case it is an array of an array or so?
} else { | ||
$args .= ', '; | ||
} | ||
$args .= $name . '=' . $value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi: Was wondering if we need to escape something here but by the looks not needed as it is printed with {{ lastError.message|e('url') }}
Left a few comments but otherwise looks 👍 |
* Add ability to print arguments in fatal error trace. * Add sum of blob content to analyze archive tables command. * Fixing tests. * Fixing tests. * fixing test * json_encode instead of strval * fix test
* Add ability to print arguments in fatal error trace. * Add sum of blob content to analyze archive tables command. * Fixing tests. * Fixing tests. * fixing test * json_encode instead of strval * fix test
Changes: