New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In piwik.updatePeriodParamsFromUrl() get period/date values from hash or URL. #13268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Aug 9, 2018
Note: found another issue while testing, don't merge yet |
mattab
requested changes
Aug 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add UI test for period=range use case on All Websites dashboard (this is not the first time this breaks)
please let me know also when this is finished testing and can be merged? |
@mattab can be merged. |
Looks good, thanks @diosmosis |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
… or URL. (matomo-org#13268) * In piwik.updatePeriodParamsFromUrl() get period/date values from hash or URL. * Remove date parameter from defaults in ajaxHelper, already handled properly below. * Remove .only * fixing tests & add new test for MultiSites * correct screenshot * upload screenshot + remove rejected change * Remove port in Url::isLocalHost().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiSites dashboard does not use a hash so the date/period values were not found. So the currentDateString was not set correctly but only for range periods.
UI tests did not pick this up because MultiSites isn't tested w/ every type of period in the URL (doing so would add a lot of time to the tests). I added unit tests for the function in question in this PR.
Fixes #13266
Fixes #13271