Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In piwik.updatePeriodParamsFromUrl() get period/date values from hash or URL. #13268

Merged
merged 7 commits into from Aug 11, 2018

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Aug 9, 2018

MultiSites dashboard does not use a hash so the date/period values were not found. So the currentDateString was not set correctly but only for range periods.

UI tests did not pick this up because MultiSites isn't tested w/ every type of period in the URL (doing so would add a lot of time to the tests). I added unit tests for the function in question in this PR.

Fixes #13266
Fixes #13271

@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 9, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 9, 2018
@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 9, 2018
@diosmosis
Copy link
Member Author

Note: found another issue while testing, don't merge yet

Copy link
Member

@mattab mattab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add UI test for period=range use case on All Websites dashboard (this is not the first time this breaks)

@mattab
Copy link
Member

mattab commented Aug 10, 2018

please let me know also when this is finished testing and can be merged?

@diosmosis
Copy link
Member Author

@mattab can be merged.

@mattab
Copy link
Member

mattab commented Aug 11, 2018

Looks good, thanks @diosmosis

@mattab mattab merged commit 7842661 into 3.x-dev Aug 11, 2018
@mattab mattab deleted the 13266-date-period-url branch August 11, 2018 07:17
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
… or URL. (matomo-org#13268)

* In piwik.updatePeriodParamsFromUrl() get period/date values from hash or URL.

* Remove date parameter from defaults in ajaxHelper, already handled properly below.

* Remove .only

* fixing tests & add new test for MultiSites

* correct screenshot

* upload screenshot + remove rejected change

* Remove port in Url::isLocalHost().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants