@diosmosis opened this Pull Request on August 9th 2018 Member

MultiSites dashboard does not use a hash so the date/period values were not found. So the currentDateString was not set correctly but only for range periods.

UI tests did not pick this up because MultiSites isn't tested w/ every type of period in the URL (doing so would add a lot of time to the tests). I added unit tests for the function in question in this PR.

Fixes #13266
Fixes #13271

@diosmosis commented on August 10th 2018 Member

Note: found another issue while testing, don't merge yet

@mattab commented on August 10th 2018 Member

please let me know also when this is finished testing and can be merged?

@diosmosis commented on August 10th 2018 Member

@mattab can be merged.

@mattab commented on August 11th 2018 Member

Looks good, thanks @diosmosis

This Pull Request was closed on August 11th 2018
Powered by GitHub Issue Mirror