Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix theme.less include #13265

Merged
merged 1 commit into from Aug 9, 2018
Merged

fix theme.less include #13265

merged 1 commit into from Aug 9, 2018

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Aug 8, 2018

Fix minor regression of #13250

plugins/Morpheus/stylesheets/theme-advanced.less and plugins/Morpheus/stylesheets/theme.less got deleted, but only the include in plugins/Morpheus/stylesheets/main.less has been removed.

Because of this less keeps a @import "theme"; in the CSS file and the browser tries to fetch https://demo.matomo.org/theme which causes a 404.

@Findus23 Findus23 added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Aug 8, 2018
@Findus23 Findus23 added this to the 3.6.0 milestone Aug 8, 2018
@mattab mattab merged commit 6112cc2 into 3.x-dev Aug 9, 2018
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 9, 2018
@sgiehl sgiehl deleted the no-theme branch August 9, 2018 09:35
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@Findus23 Findus23 restored the no-theme branch October 4, 2019 09:49
@sgiehl sgiehl deleted the no-theme branch February 10, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants