Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ui tests #13259

Merged
merged 2 commits into from Aug 7, 2018
Merged

Fix ui tests #13259

merged 2 commits into from Aug 7, 2018

Conversation

diosmosis
Copy link
Member

Updated screenshots + one other regression fixed:

  • make sure theme variables are generated at start of merged less so themes can override in LESS if they want.

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Aug 7, 2018
@diosmosis diosmosis merged commit 0fb534d into 3.x-dev Aug 7, 2018
@diosmosis diosmosis deleted the fix-ui-tests branch August 7, 2018 01:33
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Fix ui tests (matomo-org#13259)
3a9ba43 
* Put generated @theme LESS variables before everything else so theme LESS can override them.

* Update screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diosmosis