Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: Closing download popup sometimes doesn't work #13255

Open
tsteur opened this issue Aug 6, 2018 · 1 comment
Open

Demo: Closing download popup sometimes doesn't work #13255

tsteur opened this issue Aug 6, 2018 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
For Prioritization

Comments

@tsteur
Copy link
Member

tsteur commented Aug 6, 2018

On mobile (Android 7, Chrome) I found it hard to close the popup. I had to click like 10 times on the x until I had clicked a position where it actually worked.

screenshot_20180807-102318
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Aug 6, 2018
@Findus23
Copy link
Member

The button is really hard to hit as it is only 12x12px large. This change doesn't change the looks apart from moving it away a bit from the right corner, but makes the clickable area 46x46px large.
As this is not a part from the Matomo repo, I can't make a PR, so the diff is below:

diff --git a/before.css b/after.css
index 67563d5bd1..bfb18bd2d2 100644
--- a/before.css
+++ b/after.css
@@ -1,7 +1,7 @@
 .premiumFooterBanner .icon-close {
     position: absolute;
     right: 12px;
-    margin-top: 17px;
+    padding: 17px;
     display: inline-block;
     background: #263238;
     font-size: 12px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
3 participants
@tsteur @Findus23 @innocraft-automation