Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined variable error when rendering email reports #13253

Merged
merged 1 commit into from Aug 6, 2018
Merged

Fix undefined variable error when rendering email reports #13253

merged 1 commit into from Aug 6, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 6, 2018

ocurred in latest 3.x-dev tests:

1) Piwik\Plugins\Ecommerce\tests\System\EcommerceOrderWithItemsTest::testApi with data set #36 ('ScheduledReports.generateReport', array('_scheduled_report_in_html_tables_only', '2011-04-05 00:11:42', array('week'), 'original', 'html', array(1, 'html', 4)))
Exception: Variable "tableBgColor" does not exist.

seems to be a regression of #13250

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Aug 6, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Aug 6, 2018
@sgiehl sgiehl merged commit 43d3acb into 3.x-dev Aug 6, 2018
@sgiehl sgiehl deleted the reportstylesfix branch August 6, 2018 17:40
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Fix undefined variable error when rendering email reports (matomo-org…
67d060f 
…#13253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sgiehl