Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing regressions causing UI tests to fail #13252

Merged
merged 6 commits into from Aug 6, 2018
Merged

Fixing regressions causing UI tests to fail #13252

merged 6 commits into from Aug 6, 2018

Conversation

diosmosis
Copy link
Member

Changes:

  • Request.initAuthenticationObject is not always called now so use different event for login whitelist.
  • default value for form field may not be valid JSON so deal w/ that case.
  • date parameter should be forwarded as default value in ajaxHelper

CC @matomo-org/core-team will be merging if build passes.

@diosmosis diosmosis added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Aug 6, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 6, 2018
@diosmosis diosmosis merged commit 89210df into 3.x-dev Aug 6, 2018
@diosmosis diosmosis deleted the fix-ui-tests branch August 6, 2018 05:34
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Fixing regressions causing UI tests to fail (matomo-org#13252)
83e517f 
* Request.initAuthenticationObject is not always called now so use different event.

* default value for form field may not be JSON.

* Add date parameter as default value in ajaxHelper in case it is needed.

* update screenshot

* Update screenshot.

* Do not show default value when it is an array and only contains undefined values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab