Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all emails use the pretty HTML emails with branding #13251

Closed
diosmosis opened this issue Aug 6, 2018 · 4 comments
Closed

Make all emails use the pretty HTML emails with branding #13251

diosmosis opened this issue Aug 6, 2018 · 4 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
3.8.0

Comments

@diosmosis
Copy link
Member

diosmosis commented Aug 6, 2018 •
edited

After #13250 theme variables will be defined in a class and the LESS variables will be generated in an event. Before these APIs are made public the following things need to be determined/done:

  • Non-report emails need to be themed this way.
  • Every part of report emails need to use the correct theme variables.
  • If there are redundant properties in EmailStyles and ThemeStyles they should be resolved.
  • If it should be allowed, PDF reports should be themed the same way as well.

At the moment the styling of reports/emails isn't entirely consistent so can't be made public API.
@diosmosis diosmosis added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Aug 6, 2018
@diosmosis diosmosis added this to the 3.7.0 milestone Aug 6, 2018
@diosmosis diosmosis added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Aug 6, 2018
@diosmosis diosmosis mentioned this issue Aug 6, 2018
Merged
@tsteur
Copy link
Member

tsteur commented Oct 8, 2018

@diosmosis is there still much to do? Not really sure what's missing. I don't think we want to allow people to create "themes" or "change colors" for scheduled reports as long as the email header uses the theme style and logo.

@diosmosis
Copy link
Member Author

I think there are emails that are not styled at all (like the password reset email). I don't know how many email twig files use hardcoded inline styles instead of using the ...Styles classes. Not sure about redundant properties, don't think PDF reports have been styled.

@mattab
Copy link
Member

mattab commented Oct 8, 2018

Non-report emails need to be themed this way.

Now that you mention it, it would be I think good to have the consistent theming across all emails sent 👍 For the other points not sure, but maybe they don't take long?

@mattab mattab changed the title Standardize theming of e-mails and make API public Make all emails use the pretty HTML emails with branding Oct 11, 2018
@mattab
Copy link
Member

mattab commented Oct 11, 2018 •
edited

Just renamed the issue title to clarify the impact from user point of view.

@diosmosis diosmosis mentioned this issue Dec 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab