Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email theming improvements #13250

Merged
merged 4 commits into from Aug 6, 2018
Merged

email theming improvements #13250

merged 4 commits into from Aug 6, 2018

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Aug 5, 2018 •
edited

Changes:

  • Move email/theme styles to classes.
  • Generate @theme-... variables in LESS from those classes.
  • Use these variables in email HTML.

Refs #13223

@diosmosis diosmosis added the Needs Review PRs that need a code review label Aug 5, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 5, 2018
@diosmosis diosmosis changed the title 13223 improvements email theming improvements Aug 5, 2018
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 5, 2018
@diosmosis diosmosis mentioned this pull request Aug 6, 2018
Closed
@mattab mattab merged commit 325b38d into 3.x-dev Aug 6, 2018
@mattab mattab deleted the 13223-improvements branch August 6, 2018 14:16
@sgiehl sgiehl mentioned this pull request Aug 6, 2018
Merged
@Findus23 Findus23 mentioned this pull request Aug 8, 2018
Merged
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
email theming improvements (matomo-org#13250)
6244886 
* Move email/theme style variables to classes and generate LESS based on those.

* Fix uses of email/theme styles.

* Remove debugging code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab