Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconstruct partial stack traces for fatal errors. #13238

Merged
merged 5 commits into from Aug 3, 2018
Merged

Reconstruct partial stack traces for fatal errors. #13238

merged 5 commits into from Aug 3, 2018

Conversation

diosmosis
Copy link
Member

screen shot 2018-08-01 at 1 34 02 am

Fixes #13196

@diosmosis diosmosis added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 1, 2018
@diosmosis diosmosis added this to the 3.6.0 milestone Aug 1, 2018
@mattab
Copy link
Member

mattab commented Aug 1, 2018

@diosmosis the builds are failing in https://travis-ci.org/matomo-org/matomo/builds/410699560?utm_source=github_status&utm_medium=notification

mattab
mattab approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@mattab mattab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge when builds will pass @diosmosis

@diosmosis diosmosis merged commit f8ea46b into 3.x-dev Aug 3, 2018
@diosmosis diosmosis deleted the 13196-fatal-error-stack branch August 3, 2018 01:01
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@diosmosis @InfinityVoid
Reconstruct partial stack traces for fatal errors. (matomo-org#13238)
749161d 
* Reconstruct partial stack traces for fatal errors.

* tweak to fatal error breadcrumb

* Add docs + fix test.

* Add fatal error test and improve fatal error stack trace a bit.

* fix test on travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattab mattab mattab approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @mattab