Noticed the color of Table of content regressed in the branch (it used to be darker grey):

The main use case for this issue/PR is to be compatible with White Label. Just tested to configure WhiteLabel like this:

and the HTML email report is un-changed.

-> was it supposed to work maybe?

Created a WhiteLabel PR, here is a pic:

BTW, original issue should mention WhiteLabel if that is the main reason for it.

BTW, original issue should mention WhiteLabel if that is the main reason for it.

oops, sorry forgot to mention this!

LGTM, just the tests needs fixing (minor changes in the html/pdf reports)

As mentioned in other PR eventually be good to

1. Use an object instead of an array for getDefaultEmailStyles so auto completion and refactoring etc works . Like class EmailStyles { public $brandNameLong = ''; }

2. Eventually we should define theme colors only in one place. Now a theme designer needs to set it in php plus less. Ideally we would only do this in PHP. There could be one Theme object to configure theme colors like class ThemeConfiguration { public $colorText = ''; public $colorLink = ''; } and then the class EmailStyles would remove quite a few properties and use where possible those colors. There wouldn't need to be any theme.less anymore as all colors would be possible to configure through PHP in one place. PHP would then add the less theme variables through AssetManager.addStylesheets event.

I think this should be done for consistency maybe at the latest in Matomo 4 or 5, or now if not too much work. Could be quick. FYI @mattab @diosmosis

Could add these to new issue(s) for prioritization.

@diosmosis sounds good, could you create a new issue in 3.7.0?

will do

Created a PR and this issue: #13251