Add privacy policy/terms and conditions settings and display in bottom of certain pages. #13219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
|
If just one link is defined:
|
|
Looks pretty good. I wonder if at some point we also might want to add "Powered by Matomo" there :) Off topic though :) |
sgiehl
requested changes
Jul 30, 2018
| $module = Common::getRequestVar('module', false); | ||
| if ($module == 'Login') { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Actually that check is redundant, as all users on the login pages are anonymous. But guess we could leave it there for a better understanding
There was a problem hiding this comment.
I see, will remove this if
| * @link https://www.innocraft.com/ | ||
| * @license For license details see https://www.innocraft.com/license | ||
| */ | ||
| namespace Piwik\Plugins\PrivacyManager; |
There was a problem hiding this comment.
Can't use that license header here. Maybe we should rebase that branch, so it isn't anywhere in the history
diosmosis
force-pushed
the
12938-privacy-urls
branch
from
9081bbd
to
38a13af
Compare
|
@sgiehl updated |
mattab
approved these changes
Jul 31, 2018
sgiehl
force-pushed
the
12938-privacy-urls
branch
from
46fa2a4
to
05658b0
Compare
sgiehl
force-pushed
the
12938-privacy-urls
branch
from
8e19743
to
e0adc69
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…m of certain pages. (matomo-org#13219) * Add privacy policy/terms and conditions settings and display in bottom of certain pages. * tweak * simplify PrivacyManager::shouldRenderFooterLinks(). * Update system test files * removes typo * do not render view if no links available * Remove footer margin in embedded widget. * ensure footer margin doesn't change (for UI tests) * update ui files
This was referenced Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login page:
Dashboard (for anonymous user):
Another normal page (for anonymous user):
Widgetized (when enabled):
Fixes #12938