Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During installation, only show the SSL warning if Matomo is not used over SSL #13216

Closed
mattab opened this issue Jul 27, 2018 · 0 comments · Fixed by #13217 or #13218
Closed

During installation, only show the SSL warning if Matomo is not used over SSL #13216

mattab opened this issue Jul 27, 2018 · 0 comments · Fixed by #13217 or #13218
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.6.0

Comments

@mattab
Copy link
Member

mattab commented Jul 27, 2018

in 3.6.0-b1 when installing Matomo over SSL we see this: https://media.githubusercontent.com/media/matomo-org/matomo/afe8e43cc2782f7f51289d571c1aee17037ab80d/plugins/Installation/tests/UI/expected-screenshots/Installation_system_check.png

However at this point the config.ini.php file does not exist yet, therefore we need to make two changes during Installation process:

  1. the diagnostics should be hidden when Matomo is used over SSL
  2. when Matomo is not used over SSL the diagnostics should simply say We recommend using Matomo over secure SSL connections only. Please <a href='https://.....'>click here continue the installation process over SSL.</a>

So this issue only changes behavior during the installation process.
@mattab mattab added this to the 3.6.0 milestone Jul 27, 2018
@mattab mattab mentioned this issue Jul 27, 2018
Merged
@sgiehl sgiehl mentioned this issue Jul 27, 2018
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
1 participant
@mattab