Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create automated test to make sure woff2 files are up to date #13210

Closed
diosmosis opened this issue Jul 25, 2018 · 4 comments
Closed

Create automated test to make sure woff2 files are up to date #13210

diosmosis opened this issue Jul 25, 2018 · 4 comments
Assignees
@diosmosis
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
3.13.1

Comments

@diosmosis
Copy link
Member

Refs #12695

One way might be to just run woff2_compress in a test and see if the result is the same as what's in git. A test like this would probably be added to ReleaseCheckListTest. Would need to add woff2 to travis.

woff2 is not available as a package on travis, but it seems it can be built from source (and then added to a travis cache directory), see:

https://github.com/ManageIQ/font-fabulous/blob/master/.travis.yml
@diosmosis diosmosis added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Jul 25, 2018
@diosmosis diosmosis added this to the 3.7.0 milestone Jul 25, 2018
@diosmosis diosmosis mentioned this issue Jul 25, 2018
Merged
@tsteur
Copy link
Member

tsteur commented Jul 25, 2018 •
edited

I don't think woff2 tests are needed. Woff2 is used by default by all modern browsers, and all the fonts are generated in one go just like .woff, .ttf, ... when we edit the font. Can we close the issue maybe?

@Findus23
Copy link
Member

@tsteur Unfortunately they are not generated in one go as icomoon doesn't allow creating woff2 files in the free version.

@mattab
Copy link
Member

mattab commented Oct 8, 2018

@Findus23 thanks for the details. Would you maybe be able to create the test maybe?

@mattab mattab modified the milestones: 3.7.0, 3.8.0 Oct 8, 2018
@Findus23 Findus23 mentioned this issue Oct 8, 2018
Closed
@diosmosis diosmosis self-assigned this Feb 18, 2019
@mattab mattab modified the milestones: 3.9.0, 3.10.0 Mar 18, 2019
@mattab mattab added this to the 3.11.0 milestone May 28, 2019
@mattab mattab modified the milestones: 3.11.0, 3.12.0 Jul 23, 2019
@mattab mattab modified the milestones: 3.12.0, 3.13.0 Oct 22, 2019
@mattab mattab modified the milestones: 3.13.0, 3.13.1 Nov 27, 2019
@diosmosis
Copy link
Member Author

Fixed by #15172

@GTVolk GTVolk mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
3.13.1
Development

Successfully merging a pull request may close this issue.

Woff2 test matomo-org/matomo
4 participants
@diosmosis @tsteur @mattab @Findus23