Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Access to Matomo Updater via Webinterface #13201

Closed
wants to merge 1 commit into from

Conversation

daylicron
Copy link

Useful if your're running Matomo in a multi server environment. Disabled by setting:
enable_auto_updates = 0

@tsteur
Copy link
Member

tsteur commented Jul 24, 2018

Just checking: Are the links to those URLs already removed when the auto update is disabled?

If yes, be good to merge.

@daylicron
Copy link
Author

Unfortunately not. That's why we had to implement this. With the given options for config.ini.php there is no way to disable Matomo updates via the webinterface.

@mattab
Copy link
Member

mattab commented Jul 25, 2018

Thanks for the PR @daylicron 👍 Feedback:

  • Instead of duplicating the code could you create a method in the class like checkAutoUpdateIsPossible
  • which, if not, throws an exception explaining that auto update is disabled? This way users know the problem which would be better than being redirected silently.

@mattab mattab added this to the 3.7.0 milestone Sep 1, 2018
@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Sep 1, 2018
@mattab mattab removed this from the 3.7.0 milestone Sep 1, 2018
@sgiehl
Copy link
Member

sgiehl commented Feb 25, 2019

@daylicron are you able to update the PR according to @mattab's suggestions?

@mattab
Copy link
Member

mattab commented Jun 27, 2019

Thank you for this proposed pull request.

Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit).

We hope you understand this and we look forward to seeing an update from you on this pull request or another one!

Thanks.

@mattab mattab closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants