New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Segmented Visitor Log with segments containing spaces #13198
Conversation
Shouldn't the parameter be encoded automatically in ajax requests? Seems like this would double encode it (which should work because matomo handles it specifically, but it seems like a fix that could cause problems later). Maybe we should be urlencoding the values that can have spaces when adding the segment label? |
Left a comment at #13113 |
Yes, but then i see this code:
so the segment parameter is a special case/hack and not URL encoded as it's assumed by our Ajax helper that the value is already properly URL encoded. so URL encoding it manually as done in this PR is needed it seems... |
hi guys, I have updated to 3.6 version a few weeks ago and I still experience this issue with URLs containing whitespaces. This is not clear if this PR is in 3.6 ? If yes so is it supposed to fix the issue ? |
It's supposed to work, please can you create new a issue? @eetasse |
See: #13460 |
fixes #13113