Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames console to Matomo #13192

Merged
merged 2 commits into from Jul 23, 2018
Merged

Renames console to Matomo #13192

merged 2 commits into from Jul 23, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 22, 2018

and changes --piwik-domain option to --matomo-domain

fixes #12924

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 22, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jul 22, 2018
@sgiehl sgiehl mentioned this pull request Jul 22, 2018
Merged
@sgiehl sgiehl added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Jul 22, 2018
@sgiehl
Renames console to Matomo
d73c22d 
and changes --piwik-domain option to --matomo-domain
@diosmosis
Copy link
Member

Would the eventual removal of --piwik-domain be put in a list somewhere? Just to protect against forgetting.

diosmosis
diosmosis approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but looks good.

@mattab mattab mentioned this pull request Jul 23, 2018
Open
21 tasks
@sgiehl
Copy link
Member Author

sgiehl commented Jul 23, 2018

Would the eventual removal of --piwik-domain be put in a list somewhere? Just to protect against forgetting.

@diosmosis updated the list in #12420

@sgiehl sgiehl removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jul 23, 2018
@diosmosis diosmosis merged commit 8d3d720 into 3.x-dev Jul 23, 2018
@diosmosis diosmosis deleted the consolerename branch July 23, 2018 21:38
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Renames console to Matomo (matomo-org#13192)
85be086 
and changes --piwik-domain option to --matomo-domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Console is named Piwik instead of Matomo plus matomo-domain option
2 participants
@sgiehl @diosmosis