Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed wording of YouAreOptedIn #13187

Closed
wants to merge 4 commits into from

Conversation

electric-paper
Copy link

@electric-paper electric-paper commented Jul 20, 2018

fixes #12954

@Findus23 Findus23 changed the title Issue 12954: Changed wording of YouAreOptedIn Changed wording of YouAreOptedIn Jul 20, 2018
@Findus23 Findus23 added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Jul 20, 2018
@fdellwing
Copy link
Contributor

I'm not an english native, but shouldn't it be You are currently not opted out.?

@electric-paper
Copy link
Author

Of course, you're right. Changed it to You are currently not opted out.
My apologies.

@tsteur
Copy link
Member

tsteur commented Jul 24, 2018

Looks good 👍 Any chance we can change the name of the translation key itself? Eg to "YouAreNotOptedOut" and remove "YouAreOptedIn"?

This will be needed so it gets translated in all other languages. Otherwise translators wouldn't notice that the English translation changed and they wouldn't be requested to translate it.

@electric-paper
Copy link
Author

Changed the key to YouAreNotOptedOut
I'm not quite sure about the failing checks though, seems to be a normal thing?

@diosmosis diosmosis added this to the 3.7.0 milestone Aug 8, 2018
@diosmosis
Copy link
Member

I think the text here could be shortened to just "You are not opted out." 'currently' seems unnecessary here. What does everyone think?

@mattab
Copy link
Member

mattab commented Aug 8, 2018

sounds good @diosmosis

@tsteur
Copy link
Member

tsteur commented Sep 8, 2018

To get this merged I would say easiest is to create a new PR with only the change in optOut.twig https://github.com/matomo-org/matomo/pull/13187/files#diff-51d31859e47190479808b5b0d8b89b87 and the change in en.json as we cannot merge any changes to other language files unfortunately. Would that be possible?

@tsteur
Copy link
Member

tsteur commented Sep 24, 2018

@electric-paper will you have time to adjust the PR? Otherwise I can create a new PR for this

@tsteur
Copy link
Member

tsteur commented Oct 4, 2018

Created the PR here: #13538 cheers @electric-paper for this change 👍

@tsteur tsteur closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please change wording of "You are currently opted in."
6 participants