I'm not an english native, but shouldn't it be
You are currently not opted out.?
Of course, you're right. Changed it to
You are currently not opted out.
Looks good 👍 Any chance we can change the name of the translation key itself? Eg to "YouAreNotOptedOut" and remove "YouAreOptedIn"?
This will be needed so it gets translated in all other languages. Otherwise translators wouldn't notice that the English translation changed and they wouldn't be requested to translate it.
Changed the key to
I'm not quite sure about the failing checks though, seems to be a normal thing?
I think the text here could be shortened to just "You are not opted out." 'currently' seems unnecessary here. What does everyone think?
To get this merged I would say easiest is to create a new PR with only the change in
optOut.twig https://github.com/matomo-org/matomo/pull/13187/files#diff-51d31859e47190479808b5b0d8b89b87 and the change in
en.json as we cannot merge any changes to other language files unfortunately. Would that be possible?
@electric-paper will you have time to adjust the PR? Otherwise I can create a new PR for this