New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed wording of YouAreOptedIn #13187
Conversation
I'm not an english native, but shouldn't it be |
Of course, you're right. Changed it to |
Looks good 👍 Any chance we can change the name of the translation key itself? Eg to "YouAreNotOptedOut" and remove "YouAreOptedIn"? This will be needed so it gets translated in all other languages. Otherwise translators wouldn't notice that the English translation changed and they wouldn't be requested to translate it. |
Changed the key to |
I think the text here could be shortened to just "You are not opted out." 'currently' seems unnecessary here. What does everyone think? |
sounds good @diosmosis |
To get this merged I would say easiest is to create a new PR with only the change in |
@electric-paper will you have time to adjust the PR? Otherwise I can create a new PR for this |
Created the PR here: #13538 cheers @electric-paper for this change 👍 |
fixes #12954