Do not load/apply local DI config in tests #13182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I often have tests failing because I have in my local `config/config.php` a DI value overwritten which is set in `plugins/*/config/test.php` or `plugins/*/config/config.php` for example. I was thinking a quick fix by to ignore the local config file when executing tests which is I presume similar to what we do with the config ini file?
|
Makes sense to me, tests should control the environment they run in. |
mattab
added
the
c: Tests & QA
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often have tests failing because I have in my local
config/config.phpa DI value overwritten which is set inplugins/*/config/test.phporplugins/*/config/config.phpfor example. I was thinking a quick fix by to ignore the local config file when executing tests which is I presume similar to what we do with the config ini file?Any thoughts @diosmosis ?
Will need to see if tests still pass but I would expect so.