Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure segmented visitor log numeration doesn't break #13169

Merged
merged 2 commits into from Jul 17, 2018
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 16, 2018

Before there was a line break after the numeration if the number was higher than 99. This should now look good until the number is higher than 99999 (which should not happen due to the config limitation)

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Jul 16, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jul 16, 2018
@diosmosis diosmosis merged commit 6a50544 into 3.x-dev Jul 17, 2018
@diosmosis diosmosis deleted the segvlog branch July 17, 2018 02:25
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Ensure segmented visitor log numeration doesn't break

* Update expected UI test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants