Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fetch the environment in list of processes #13166

Closed
wants to merge 1 commit into from
Closed

Do not fetch the environment in list of processes #13166

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 12, 2018

Small tweak to #13161 . Noticed this on a different linux... otherwise the same archive command would appear multiple times see eg

string(468) "11112 ?        Ss     0:00 /bin/sh -c php /home/foo/console core:archive --no-ansi >> /home/foo/test.log EDITOR=nano LANG=en_US.UTF-8 MAILTO=foo@foo.com SHELL=/bin/sh HOME=/home/fooPATH=/usr/bin:/bin LOGNAME=foo"
  string(502) "11113 ?        S      0:00 /usr/php /home/foo/console core:archive --no-ansi SHELL=/bin/sh MAILTO=foo@foo.com PHPRC=/home/foo/admin/config/php PATH=/usr/bin:/bin PWD=/home/foo EDITOR=nano LANG=en_US.UTF-8 SHLVL=0 HOME=/home/foo LOGNAME=foo"

When using ps ex in this case it figured the same archiver is running twice when it is only once.

@tsteur
Do not fetch the environment in list of processes
1cece2f 
Small tweak to #13161 . Noticed this on a different linux... otherwise the same archive command would appear multiple times see eg 

```
string(468) "11112 ?        Ss     0:00 /bin/sh -c php /home/foo/console core:archive --no-ansi >> /home/foo/test.log EDITOR=nano LANG=en_US.UTF-8 MAILTO=foo@foo.com SHELL=/bin/sh HOME=/home/fooPATH=/usr/bin:/bin LOGNAME=foo"
  string(502) "11113 ?        S      0:00 /usr/php /home/foo/console core:archive --no-ansi SHELL=/bin/sh MAILTO=foo@foo.com PHPRC=/home/foo/admin/config/php PATH=/usr/bin:/bin PWD=/home/foo EDITOR=nano LANG=en_US.UTF-8 SHLVL=0 HOME=/home/foo LOGNAME=foo"
```

When using `ps ex` in this case it figured the same archiver is running twice when it is only once.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 12, 2018
@tsteur tsteur added this to the 3.6.0 milestone Jul 12, 2018
@tsteur tsteur closed this Jul 12, 2018
@tsteur tsteur deleted the fetchlistofprocesses branch July 12, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur