Add possibility to configure the number of max concurrent archivers: --concurrent-archivers #13161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Enhancement
tsteur
added a commit
that referenced
this pull request
Jul 12, 2018
Small tweak to #13161 . Noticed this on a different linux... otherwise the same archive command would appear multiple times see eg ``` string(468) "11112 ? Ss 0:00 /bin/sh -c php /home/foo/console core:archive --no-ansi >> /home/foo/test.log EDITOR=nano LANG=en_US.UTF-8 MAILTO=foo@foo.com SHELL=/bin/sh HOME=/home/fooPATH=/usr/bin:/bin LOGNAME=foo" string(502) "11113 ? S 0:00 /usr/php /home/foo/console core:archive --no-ansi SHELL=/bin/sh MAILTO=foo@foo.com PHPRC=/home/foo/admin/config/php PATH=/usr/bin:/bin PWD=/home/foo EDITOR=nano LANG=en_US.UTF-8 SHLVL=0 HOME=/home/foo LOGNAME=foo" ``` When using `ps ex` in this case it figured the same archiver is running twice when it is only once.
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…atomo-org#13161) * Add possibility to limit max archivers * add missing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a setting
concurrent-requests-per-websiteto specify how many requests one archiver may issue at a time. This new settingconcurrent-archiversallows additionally to limit how many archivers should run max. This is useful when an archiver takes a very long time and you don't want to eventually have like 10 or 20 archivers running at the same time.I don't think this needs to be mentioned in the developer changelog.