Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor internal formatting tweak for detecting an already running command #13154

Closed
wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 10, 2018

This change is really not needed as in both cases in the command to check and in the list of commands we currently replace the result with an empty string and both apply same behavior. It's really just for debugging/reading purposes...

Currently, a matched string would be replaced from
from period=month&date=2018-04-08,2018-04-30&format=php... to
from period=monthformat=php... whereas with this PR it would be period=month&format=php...

This change is really not needed as in both cases in the command to check and in the list of commands we currently replace the result with an empty string and both apply same behavior. It's really just for debugging/reading purposes... 

Currently, a matched string would be replaced from
from `period=month&date=2018-04-08,2018-04-30&format=php...` to 
from `period=monthformat=php...` whereas with this PR it would be `period=month&format=php...`
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 10, 2018
@tsteur
Copy link
Member Author

tsteur commented Jul 24, 2018

It is actually not needed.

@tsteur tsteur closed this Jul 24, 2018
@tsteur tsteur deleted the climultiinternalformatting branch July 24, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant