@sgiehl opened this Issue on July 9th 2018 Member

We show an overview over all available and set configurations in Matomo administration.
Therefor the global.ini.php is parsed.
As we have a few config values that are completely commented out by default this view is a bit broken:

image

image

Those lines also include config values that are completely commented out.
Merging https://github.com/matomo-org/component-ini/pull/9 and updating the component might help a bit. But those value entries might be hidden completely afterwards.

Maybe we should provide a default value for ALL config values!?

@matomo-org/core-team anyone any opinion on that?

@diosmosis commented on July 9th 2018 Member

Looking at matomo-org/component-ini#9 it might fix it? Or I guess the problem is cors_domains wouldn't display at all then like cors_domains? I wonder if you can set it to an empty array in INI...

@sgiehl commented on July 9th 2018 Member

with the component changes, config keys that are commented out wouldn't be displayed at all in most cases (if there are blank lines in between). Imho it would be the best solution to have default values for all config values. But afaik there's no possibility to set an empty array in INI.

@tsteur commented on July 9th 2018 Member

with the component changes, config keys that are commented out wouldn't be displayed at all in most cases (if there are blank lines in between)

be good if they could still be displayed

The problem otherwise really is that some settings shouldn't be set by default like the proxy headers or proxy ips maybe and especially instance_id. Also we can never really guarantee that a default value is set...
Just a random thought as there are not too many with no value... can we somehow whitelist them and then parse somehow the comments for eg ; $whitelistedConfig and ;$whitelistedConfig to detect them somehow? Haven't looked into it...

Powered by GitHub Issue Mirror