Change on svgBasePath to work with reverse proxy #13142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be better if we change $view->piwikUrl with specific domain
|
@tinwinaung would you mind trying to explain what problem this change will solve? Is the hostname included not the correct one? |
|
I can see how this might be a problem if |
|
If Matomo is behind a reverse proxy and installed in a sub-path, please follow instructions in https://matomo.org/faq/how-to-install/faq_98/ IMO this change shouldn't be needed if you follow the instructions? please re-open if it's not working and explain the steps you took. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be better if we change $view->piwikUrl with specific domain