Allow hostnames to be configured in login whitelist #13137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May be useful in combination with for example DynDNS providers. Or should we rather have a `login.whitelist.hostnames`?
sgiehl
requested changes
Jul 7, 2018
There was a problem hiding this comment.
For me it would be fine to have the hostnames in the same setting, but we could also split it up.
Neverthless we should mention that in the config description: https://github.com/matomo-org/matomo/blob/3.x-dev/config/global.ini.php#L396-L406 and maybe the changelog as well
|
Good point 👍 Updated the global.ini.php. Not sure about the changelog as it is not directly developer related. I will update https://matomo.org/faq/how-to/faq_25543/ though. |
|
fyi @mattab I slightly changed https://matomo.org/faq/how-to/faq_25543/ by adding the hostname part. |
sgiehl
approved these changes
Jul 9, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Allow hostnames to be configured in login whitelist May be useful in combination with for example DynDNS providers. Or should we rather have a `login.whitelist.hostnames`? * Add test for resolving hostnames * document new hostname option for the login whitelist * updates UI file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be useful in combination with for example DynDNS providers. Or should we rather have a
login.whitelist.hostnames?