Hide Mobile Sidebar on desktop site #13135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so used for the mobile-left-menu. This prevents the mobile-top-menu from briefly being shown in the desktop version, when clicking the invisible 10px area on the right side.
…et' class. This prevents the leftmost 10px and rightmost 10px from being unclickable on the desktop version.'
|
Updated the PR to also make the previously unclickable 10px drag-target areas clickable on the desktop version. |
Findus23
added
the
c: Usability
|
👍 Cheers for this. Quite a few UI tests are failing now see https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/28531/ Any chance you can update the failing screenshot tests? We can otherwise do this as well to make sure no random failures are being updated or so. |
diosmosis
force-pushed
the
bugfix-mobile-sidebar-on-desktop-12531
branch
from
2fb1992
to
4f5d9ba
Compare
|
Took the liberty of updating the screenshots @justju in 3.x-dev, hope you don't mind, updating this many screenshots would have been quite the chore. Thanks for the contribution, much appreciated! |
diosmosis
added a commit
that referenced
this pull request
Jul 25, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Add hide-on-large-only class to the mobile-top-menu. This class is also used for the mobile-left-menu. This prevents the mobile-top-menu from briefly being shown in the desktop version, when clicking the invisible 10px area on the right side. * Add 'hide-on-large-only'-like media query to Materialize's 'drag-target' class. This prevents the leftmost 10px and rightmost 10px from being unclickable on the desktop version.'
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12531
This just adds the
hide-on-large-onlyto themobile-top-menu, to prevent it from being visible on the desktop site. This is equivalent to themobile-left-menuwhich already has this class. See: _menu.twig:L47