@justju opened this Pull Request on July 4th 2018 Contributor

fixes #12531

This just adds the hide-on-large-only to the mobile-top-menu, to prevent it from being visible on the desktop site. This is equivalent to the mobile-left-menu which already has this class. See: _menu.twig:L47

@justju commented on July 6th 2018 Contributor

Updated the PR to also make the previously unclickable 10px drag-target areas clickable on the desktop version.

@tsteur commented on July 24th 2018 Member

👍 Cheers for this. Quite a few UI tests are failing now see https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/28531/

Any chance you can update the failing screenshot tests? We can otherwise do this as well to make sure no random failures are being updated or so.

@diosmosis commented on July 25th 2018 Member

Took the liberty of updating the screenshots @justju in 3.x-dev, hope you don't mind, updating this many screenshots would have been quite the chore.

Thanks for the contribution, much appreciated!

This Pull Request was closed on July 25th 2018
Powered by GitHub Issue Mirror