Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check for license in test mode #13133

Merged
merged 2 commits into from Jul 7, 2018
Merged

Do not check for license in test mode #13133

merged 2 commits into from Jul 7, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 4, 2018

In my case eg system tests wouldn't install the plugin anymore and any test wouldn't run anymore for premium features cause they wouldn't have a license.

The only other alternative be to change Piwik\Plugins\Marketplace\Plugins in all tests I reckon (excerpt for when testing this class).

@tsteur
Do not check for license in test mode
d6376b0 
In my case eg system tests wouldn't install the plugin anymore and any test wouldn't run anymore for premium features cause they wouldn't have a license.
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 4, 2018
@mattab mattab added this to the 3.6.0 milestone Jul 6, 2018
sgiehl
sgiehl approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine I guess

@tsteur tsteur merged commit 5194553 into 3.x-dev Jul 7, 2018
@tsteur tsteur deleted the nolicensecheckintests branch July 7, 2018 19:26
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 28, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Do not check for license in test mode (matomo-org#13133)
50d4976 
* Do not check for license in test mode

In my case eg system tests wouldn't install the plugin anymore and any test wouldn't run anymore for premium features cause they wouldn't have a license.

* perform the tests check as late as possible so as much code as possible is covered by tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @mattab