Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to use line breaks in placeholders #13125

Merged
merged 2 commits into from Jul 2, 2018
Merged

Make it possible to use line breaks in placeholders #13125

merged 2 commits into from Jul 2, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 2, 2018

for safari those line breaks will be replaced with 200 white spaces, as line breaks aren't supported there

fixes #13035
replaces #13036

@sgiehl
Make it possible to use line breaks in placeholders
d6c9c65 
for safari those line breaks will be replaced with 200 white spaces, as line breaks aren't supported there
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 2, 2018
@sgiehl sgiehl added this to the 3.6.0 milestone Jul 2, 2018
@fdellwing
Copy link
Contributor

Please do use a invalid url, like example.com 😄 Otherwise 👍

@sgiehl
Copy link
Member Author

sgiehl commented Jul 2, 2018

changed it to http://example.com/ https://www.example.org/

@diosmosis diosmosis merged commit 1a37b84 into 3.x-dev Jul 2, 2018
@diosmosis diosmosis deleted the placeholderfix branch July 2, 2018 22:38
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@sgiehl @InfinityVoid
Make it possible to use line breaks in placeholders (matomo-org#13125)
877b850 
* Make it possible to use line breaks in placeholders

for safari those line breaks will be replaced with 200 white spaces, as line breaks aren't supported there

* use example.com and example.org as placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Placeholder for SiteUrl is displayed incorrectly
3 participants
@sgiehl @fdellwing @diosmosis